Avoid to use sass v3.5.4 #934
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some test cases fail with sass v3.5.4, and the test does snot fail in v3.5.5. with sass 3.5.3 ---- ``` $ bundle exec rspec ... 1764 examples, 0 failures ``` with sass 3.5.4 ---- ``` $ bundle exec rspec ... 1764 examples, 117 failures ``` with sass 3.5.4 ---- ``` $ bundle exec rspec ... 1764 examples, 0 failures ``` ---- I guess it is sass gem's bug. So I think scss-lint should avoid sass v3.5.4.
Merged
|
Hi @pocke , yes that was a Sass regression fixed in 3.5.5 (ref: sass/sass#2423) I've just opened a PR which includes #933 and #934. Please note that I don't want to take credits of your work here, I'm working on that PR from a long while |
|
Implemented in #935. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some test cases fail with sass v3.5.4, and the test does snot fail in v3.5.5.
with sass 3.5.3
with sass 3.5.4
with sass 3.5.5
I guess it is sass gem's bug. So I think scss-lint should avoid sass v3.5.4.